Simplify the cross-compilation build scripts. #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 95.3% 95.31% +<.01%
==========================================
Files 35 35
Lines 3197 3200 +3
==========================================
+ Hits 3047 3050 +3
Misses 150 150
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change simplifies the checks performed during cross-compilation by removing the compile-and-check performed on libmicrohttpd (which cannot work due to the different binary format)
Possible Drawbacks
This might lead to errors during compilation/linking if the wrong version of libmicrohttpd is used
Verification Process
Unit tests / Integration tests
Release Notes
Removed version checks on libmicrohttpd when cross-compiling.